Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make submodule-sync always try update cudf-pins [skip ci] #2504

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Make submodule-sync always try update cudf-pins [skip ci] #2504

merged 1 commit into from
Oct 16, 2024

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Oct 15, 2024 •
edited
Loading

fix #2484

The change try update submodule-sync script to always,

  1. check for new cudf commit without skipping subsequent steps if none are found
  2. check for any new cuDF pinned versions

@pxLi pxLi requested a review from jlowe October 15, 2024 02:59
@pxLi pxLi self-assigned this Oct 15, 2024
@pxLi pxLi added bug Something isn't working build labels Oct 15, 2024
@pxLi
Copy link
Collaborator Author

pxLi commented Oct 15, 2024

currently blocked by #2503

@pxLi pxLi marked this pull request as ready for review October 16, 2024 00:42
@pxLi
Copy link
Collaborator Author

pxLi commented Oct 16, 2024

build

@pxLi pxLi merged commit e118e6e into NVIDIA:branch-24.12 Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@pxLi pxLi

Labels
bug Something isn't working build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] submodule sync script assumes cudf commits are required to see any changes
2 participants
@pxLi @jlowe