Skip to content

Commit 5ad40ec

Browse files
authored
Refactor RapidsTestSettings imports to one suite per line (#13768)
## Description Refactor the import statements in `RapidsTestSettings.scala` to improve code readability and maintainability. ## Changes - Split the single long import statement (containing 30 test suites) into individual import lines - Each `RapidsSuite` is now imported on a separate line **Before:** ```scala import org.apache.spark.sql.rapids.suites.{RapidsCastSuite, RapidsDataFrameAggregateSuite, RapidsJsonExpressionsSuite, ...} ``` **After:** ```scala import org.apache.spark.sql.rapids.suites.RapidsCastSuite import org.apache.spark.sql.rapids.suites.RapidsDataFrameAggregateSuite import org.apache.spark.sql.rapids.suites.RapidsJsonExpressionsSuite ... ``` ## Benefits 1. **Better Readability** - Each test suite is clearly visible on its own line 2. **Cleaner Git Diffs** - When adding/removing test suites, only affected lines change 3. **Easier Maintenance** - Reduces merge conflicts when multiple branches add different suites 4. **Better Code Review** - Easier to spot which test suites are being added or removed ## Style Compliance - ✅ **No style violations** - Verified with `mvn verify` - The existing `// scalastyle:off line.size.limit` comment handles line length constraints - All license checks pass (Apache RAT) ## Testing ```bash mvn verify -pl tests -Dbuildver=330 -DskipTests ``` Result: **BUILD SUCCESS** - No compilation errors, no style violations ## Files Changed - `tests/src/test/spark330/scala/org/apache/spark/sql/rapids/utils/RapidsTestSettings.scala` Signed-off-by: Allen Xu <[email protected]> Signed-off-by: Allen Xu <[email protected]>
1 parent 17df83d commit 5ad40ec

File tree

1 file changed

+32
-1
lines changed

1 file changed

+32
-1
lines changed

tests/src/test/spark330/scala/org/apache/spark/sql/rapids/utils/RapidsTestSettings.scala

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,38 @@
1919
spark-rapids-shim-json-lines ***/
2020
package org.apache.spark.sql.rapids.utils
2121

22-
import org.apache.spark.sql.rapids.suites.{RapidsCastSuite, RapidsDataFrameAggregateSuite, RapidsJsonExpressionsSuite, RapidsJsonFunctionsSuite, RapidsJsonSuite, RapidsMathExpressionsSuite, RapidsMathFunctionsSuite, RapidsMiscFunctionsSuite, RapidsParquetAvroCompatibilitySuite, RapidsParquetColumnIndexSuite, RapidsParquetCompressionCodecPrecedenceSuite, RapidsParquetDeltaByteArrayEncodingSuite, RapidsParquetDeltaEncodingInteger, RapidsParquetDeltaEncodingLong, RapidsParquetDeltaLengthByteArrayEncodingSuite, RapidsParquetEncodingSuite, RapidsParquetFieldIdIOSuite, RapidsParquetFieldIdSchemaSuite, RapidsParquetFileFormatSuite, RapidsParquetInteroperabilitySuite, RapidsParquetPartitionDiscoverySuite, RapidsParquetProtobufCompatibilitySuite, RapidsParquetQuerySuite, RapidsParquetRebaseDatetimeSuite, RapidsParquetSchemaPruningSuite, RapidsParquetSchemaSuite, RapidsParquetThriftCompatibilitySuite, RapidsParquetVectorizedSuite, RapidsRegexpExpressionsSuite, RapidsStringExpressionsSuite, RapidsStringFunctionsSuite}
22+
import org.apache.spark.sql.rapids.suites.RapidsCastSuite
23+
import org.apache.spark.sql.rapids.suites.RapidsDataFrameAggregateSuite
24+
import org.apache.spark.sql.rapids.suites.RapidsJsonExpressionsSuite
25+
import org.apache.spark.sql.rapids.suites.RapidsJsonFunctionsSuite
26+
import org.apache.spark.sql.rapids.suites.RapidsJsonSuite
27+
import org.apache.spark.sql.rapids.suites.RapidsMathExpressionsSuite
28+
import org.apache.spark.sql.rapids.suites.RapidsMathFunctionsSuite
29+
import org.apache.spark.sql.rapids.suites.RapidsMiscFunctionsSuite
30+
import org.apache.spark.sql.rapids.suites.RapidsParquetAvroCompatibilitySuite
31+
import org.apache.spark.sql.rapids.suites.RapidsParquetColumnIndexSuite
32+
import org.apache.spark.sql.rapids.suites.RapidsParquetCompressionCodecPrecedenceSuite
33+
import org.apache.spark.sql.rapids.suites.RapidsParquetDeltaByteArrayEncodingSuite
34+
import org.apache.spark.sql.rapids.suites.RapidsParquetDeltaEncodingInteger
35+
import org.apache.spark.sql.rapids.suites.RapidsParquetDeltaEncodingLong
36+
import org.apache.spark.sql.rapids.suites.RapidsParquetDeltaLengthByteArrayEncodingSuite
37+
import org.apache.spark.sql.rapids.suites.RapidsParquetEncodingSuite
38+
import org.apache.spark.sql.rapids.suites.RapidsParquetFieldIdIOSuite
39+
import org.apache.spark.sql.rapids.suites.RapidsParquetFieldIdSchemaSuite
40+
import org.apache.spark.sql.rapids.suites.RapidsParquetFileFormatSuite
41+
import org.apache.spark.sql.rapids.suites.RapidsParquetInteroperabilitySuite
42+
import org.apache.spark.sql.rapids.suites.RapidsParquetPartitionDiscoverySuite
43+
import org.apache.spark.sql.rapids.suites.RapidsParquetProtobufCompatibilitySuite
44+
import org.apache.spark.sql.rapids.suites.RapidsParquetQuerySuite
45+
import org.apache.spark.sql.rapids.suites.RapidsParquetRebaseDatetimeSuite
46+
import org.apache.spark.sql.rapids.suites.RapidsParquetSchemaPruningSuite
47+
import org.apache.spark.sql.rapids.suites.RapidsParquetSchemaSuite
48+
import org.apache.spark.sql.rapids.suites.RapidsParquetThriftCompatibilitySuite
49+
import org.apache.spark.sql.rapids.suites.RapidsParquetVectorizedSuite
50+
import org.apache.spark.sql.rapids.suites.RapidsRegexpExpressionsSuite
51+
import org.apache.spark.sql.rapids.suites.RapidsStringExpressionsSuite
52+
import org.apache.spark.sql.rapids.suites.RapidsStringFunctionsSuite
53+
2354

2455
// Some settings' line length exceeds 100
2556
// scalastyle:off line.size.limit

0 commit comments

Comments
 (0)