Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unused config shuffle.spillThreads #11595

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Remove an unused config shuffle.spillThreads #11595

merged 2 commits into from
Oct 14, 2024

Conversation

abellina
Copy link
Collaborator

Removes an unused config spark.rapids.sql.shuffle.spillThreads from RapidsConf

@abellina abellina added ease of use Makes the product simpler to use or configure tech debt labels Oct 11, 2024
@abellina
Copy link
Collaborator Author

build

jlowe
jlowe reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config docs need to be generated, since this config appears there. Interesting that we marked this as commonly used when it has no effect?

@abellina
Copy link
Collaborator Author

config docs need to be generated, since this config appears there. Interesting that we marked this as commonly used when it has no effect?

Ah let me generate.

Agree, it has been in the repo for 4 years according to the blame history.

@abellina
Copy link
Collaborator Author

build

@abellina abellina merged commit 11964ae into NVIDIA:branch-24.12 Oct 14, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
ease of use Makes the product simpler to use or configure tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abellina @jlowe