Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 11 continuous sweep does not stop with STOP button. #589

Closed
bearbate opened this issue Jan 28, 2023 · 6 comments
Closed

Windows 11 continuous sweep does not stop with STOP button. #589

bearbate opened this issue Jan 28, 2023 · 6 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists stale Long time no reaction, will be closed soon

Comments

@bearbate
Copy link

bearbate commented Jan 28, 2023

Bug Report

NanoVNA-Saver version: 0.5.4

Current behavior:

Start continuous sweep - click STOP button but sweep does not stop
Expected behavior:

Sweep should stop

Steps to reproduce:
As above description

Beyond my pay grade

Related code:

insert short code snippets here

Other information:

@bearbate bearbate added the bug Something isn't working label Jan 28, 2023
@rjordans
Copy link
Contributor

I can confirm this also happens on Linux

@zarath
Copy link
Collaborator

zarath commented Feb 12, 2023

See #128
Any FW on any Device available which support disabling stimulus via command now?
Otherwise -> unfixable.

@zarath zarath added the duplicate This issue or pull request already exists label Feb 12, 2023
@rjordans
Copy link
Contributor

@zarath this seems to be a different issue. looks like this line misses an "or self.stopped"

@KJ7NLL
Copy link

KJ7NLL commented Feb 12, 2023

+1, same issue, but we are in Linux running v0.5.4.

if I open the "Sweep Settings" dialog and click it from "continuous" to "single" then it stops sweeping. Then I put it back to "continuous" and click "sweep" to go back to continuous. Ok for a work-around, but would be nice to click "Stop".

@rjordans
Copy link
Contributor

This should be fixed as of version 0.5.5 and can probably be closed now. @bearbate and @KJ7NLL can you confirm this now works as expected?

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale Long time no reaction, will be closed soon label Jun 30, 2023
@zarath zarath closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists stale Long time no reaction, will be closed soon
Projects
None yet
Development

No branches or pull requests

4 participants