Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-play: 155 parameters not match with the called function #9

Closed
guohl opened this issue Jan 6, 2018 · 14 comments
Closed

self-play: 155 parameters not match with the called function #9

guohl opened this issue Jan 6, 2018 · 14 comments

Comments

@guohl
Copy link

guohl commented Jan 6, 2018

No description provided.

@Narsil
Copy link
Owner

Narsil commented Jan 6, 2018

Which version are you running ? This should be fixed in master.

@guohl
Copy link
Author

guohl commented Jan 6, 2018

A___line: 155(self_play.py): game_data = play_game(model, model, mcts_simulations, conf['STOP_EXPLORATION'], self_play=True, resign_model1=resign, resign_model2=resign)
B___line: 32(self_play.py): def play_game(model1, model2, mcts_simulations, stop_exploration, self_play=False, num_moves=None, resign_model1=None, resign_model2=None)

@guohl
Copy link
Author

guohl commented Jan 6, 2018

I changed A to "game_data = play_game(model, model, mcts_simulations, conf['STOP_EXPLORATION'], True, None, resign_model1=resign, resign_model2=resign) and the result seems correct! and the game record seems reasonable.

@Narsil
Copy link
Owner

Narsil commented Jan 6, 2018

You should not have non named arguments (None is non named argument, after self_play=True, which is a named argument). Which version of python are you runninng ? Also num_moves should be None by default

@guohl
Copy link
Author

guohl commented Jan 6, 2018

the latest master

@guohl
Copy link
Author

guohl commented Jan 6, 2018

"game_data = play_game(model, model, mcts_simulations, conf['STOP_EXPLORATION'], True, None, resign_model1=resign, resign_model2=resign"

as above

@Narsil
Copy link
Owner

Narsil commented Jan 6, 2018

Which version of python are you running ?

@guohl
Copy link
Author

guohl commented Jan 6, 2018

python 3.5

@guohl
Copy link
Author

guohl commented Jan 6, 2018

it works fine only produces to much moves!
if add self fill eyes check to mask in play.py(line:12) it might be much better

@guohl
Copy link
Author

guohl commented Jan 6, 2018

screenshot from 2018-01-06 17-04-18

@Narsil
Copy link
Owner

Narsil commented Jan 6, 2018

Ok, I'm closing this, for the fill eyes use #12 plz.

@Narsil Narsil closed this as completed Jan 6, 2018
@guohl
Copy link
Author

guohl commented Jan 6, 2018

a few hours, it seems reasonable!

@guohl
Copy link
Author

guohl commented Jan 6, 2018

ok, thank you

@Narsil
Copy link
Owner

Narsil commented Jan 6, 2018

Don't be so sure, I've been running it on 9x9 for quite a while, it's still easily beatable. Looking at leela it looks like it needs quite a few games before making decent progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants