Feature: Updating "rotate_coordinates_rel_west" function in utilities to fix farm orientation for plots#556
Closed
MYMahfouz wants to merge 3 commits intoNatLabRockies:developfrom
Closed
Feature: Updating "rotate_coordinates_rel_west" function in utilities to fix farm orientation for plots#556MYMahfouz wants to merge 3 commits intoNatLabRockies:developfrom
MYMahfouz wants to merge 3 commits intoNatLabRockies:developfrom
Conversation
MYMahfouz
changed the title
rafmudaf
force-pushed
the
main
branch
2 times, most recently
from
4285b96 to
76df862
Compare
Collaborator
|
@MYMahfouz Just heads up that I updated this branch and placed it (via |
dhcho347
added a commit
to dhcho347/floris
that referenced
this pull request
May 4, 2023
Collaborator
|
Hello, I believe this functionality has been integrated into some other work in #578. It would be great if you are able to check and verify that it does provide the same functionality you were aiming for here. |
Collaborator
Collaborator
|
I'm closing this pull request since I think it is covered by #578 and #650 like @bayc and @misi9170 mentioned above. @MYMahfouz please update or reopen if this has been incorrectly closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Fixing the farm orientation before plotting, this pull request builds on the work done in an earlier pull request: #533
Related issue, if one exists
This pull request builds on the work done in an earlier pull request: #533
Fix orientation: #348, #357, #372
non-matching plot turbine with fi: #448, #451, #455, #512
Impacted areas of the software
utilities.py: fn rotate_coordinates_rel_west() adding 2 parameters (farm layout_x and layout_y)
florice_interface.py: updated calling rotate_coordinates_rel_west() within get_plane_of_points()
There other changes that I got from #533
fix orientation
v grid.py: class flowfiledplanar Grid method set_grid (Braoden flowfield, rotate mesh grid)
v utilities.py: ftn rotate_coordinates_rel_west() adding 1 parameter (inv_rot)
v floris_interface.py: method get_plane_of_points() (reverse rotating to north up)
Additional supporting information
Test results, if applicable