Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create github action to run full query microservices stack and testAll script, but never fail the PR if this task fails #2414

Open
jwomeara opened this issue Jun 11, 2024 · 1 comment
Assignees
Labels
Query Microservice TODOs TODOs to be worked AFTER the query microservices are finished

Comments

@jwomeara
Copy link
Collaborator

It would be really nice if we could update the github actions to be able to run the docker compose quickstart and run some test queries with the latest services to ensure everything is still working.

We would NOT want to fail a build if these tests fail because it could be that the datawave build is fine, but one of the microservices is in a bad state. Instead, maybe we could look into creating some kind of badge to signify whether the docker compose build is working or not.

@jwomeara jwomeara added the Query Microservice TODOs TODOs to be worked AFTER the query microservices are finished label Jun 11, 2024
@jwomeara
Copy link
Collaborator Author

The github actions that are currently in place have a commented out section that can be used to run the docker-compose deployment and ru the test-all script. This will need to be modified to not fail the build if the tests fail, and to instead update a badge in the README.md to show whether the tests have succeeded or not.

https://github.com/NationalSecurityAgency/datawave/blob/integration/.github/workflows/tests.yml#L76

@doublejai doublejai self-assigned this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query Microservice TODOs TODOs to be worked AFTER the query microservices are finished
Projects
None yet
Development

No branches or pull requests

2 participants