-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ScoredPhrase Bug #2440
Fix ScoredPhrase Bug #2440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add some additional commentary in the comments, but fundamentally this code looks ok.
For future work, it would be nice to consider restructuring the code to avoid a bunch of nested if/else statements. I'm curious how sonar would rate the cyclomatic complexity of this class.
...house/query-core/src/main/java/datawave/query/jexl/functions/ContentFunctionsDescriptor.java
Show resolved
Hide resolved
...house/query-core/src/main/java/datawave/query/jexl/functions/ContentFunctionsDescriptor.java
Outdated
Show resolved
Hide resolved
I originally wanted to break apart that method but decided not to for the sake of keeping the change set small. Since you've asked, I'm more than happy to split out the scored phrase logic into it's own method. Sonar Lint shows the method complexity at 100 -- far too much. |
I took a look at this and to do it right would require a massive expansion of scope. Wrote #2456 to track that. |
Synced w/integration just to get the Docker file fixes for the |
Fixes #2441
fieldsAndTerms