BSim: fix malformed arguments to ./configure on macOS #8483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmkurtz
added
Status: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
make-postgres.shscript fails to build PostgreSQL with OpenSSL enabled on macOS even when OpenSSL is present due to the script passing malformed arguments to./configure.The script tries to automatically specify Homebrew's
includeandlibdirectories but without spaces between the arguments, which results in the following warning from./configure:This PR simply adds a space right before each argument.
You can check if PostgreSQL is built with SSL enabled by running
postgres -c ssl=on.If your build doesn't support SSL, you will get something like this: