Skip to content
This repository has been archived by the owner on Dec 3, 2018. It is now read-only.

Create a test for incomplete proofs #9

Open
DavidVorick opened this issue Jul 29, 2015 · 3 comments
Open

Create a test for incomplete proofs #9

DavidVorick opened this issue Jul 29, 2015 · 3 comments

Comments

@DavidVorick
Copy link
Member

An incomplete proof is any time that the index is greater than the numLeaves. Not testing this case resulted in a bug, caught by fuzzing. The bug has now been fixed but there's not an explicit test exploring incomplete proofs.
@DavidVorick
Copy link
Member Author

@VoidingWarranties Are you up for it?

@VoidingWarranties
Copy link
Contributor

I was looking into this yesterday. The test seems trivial so I want to clarify some things IRL or on Slack to make sure I'm not over trivializing it.

@DavidVorick
Copy link
Member Author

I think there were some edge cases around the zero values. I forget exactly what I had in mind when I made this issue and why it wasn't simple enough to code up in just a few minutes. Maybe it was, and I was just away from a coding machine?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidVorick @VoidingWarranties