Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a suggestion? idk '-' #76

Open
Yurkhun opened this issue Dec 30, 2022 · 1 comment
Open

Just a suggestion? idk '-' #76

Yurkhun opened this issue Dec 30, 2022 · 1 comment

Comments

@Yurkhun
Copy link

Yurkhun commented Dec 30, 2022

It looks like a script that sends HTTP requests to a Twitch channel using a list of proxies and a random user agent. The requests are sent concurrently using multiple threads.

There are a few issues with this code that could potentially cause problems:

  1. The script uses the Streamlink module to fetch the stream URL for the channel, but it does not handle exceptions when the stream is not available. This could cause the script to crash if the stream is not found.

  2. The script uses a fixed number of threads (max_nb_of_threads) to send requests concurrently, which could cause problems if the number of threads is too high. You should consider using a thread pool or limiting the number of threads based on system resources.

  3. The script uses a hardcoded list of good proxies, but it does not validate the proxies or check if they are still working. This could cause issues if some of the proxies are no longer functional or if they are blocked by the server.

Overall, the code has some basic issues that need to be addressed

@Anonymous2
Copy link

Indeed, this doesn't work for some time now. We need a project manager probably, or at least someone with knowledge and some time to code to bring the project back from the grave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants