Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #15919 #15894

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix #15919 #15894

wants to merge 3 commits into from
+4 −4

Conversation

VaynePeng
Copy link

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）
  • 鸿蒙（harmony）

windows 下路径拼接错误

@VaynePeng VaynePeng mentioned this pull request Jun 17, 2024
Open
@VaynePeng
Copy link
Author

VaynePeng commented Jun 17, 2024 •
edited
Loading

解决这个问题：#15919

@yoyo837 yoyo837 linked an issue Jun 19, 2024 that may be closed by this pull request
windows 环境下 path 拼接未使用 path.join 导致返回的路径异常 #15919
Open
@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.51%. Comparing base (a8ac196) to head (179a963).

❗ Current head 179a963 differs from pull request most recent head 721f6e6

Please upload reports for the commit 721f6e6 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #15894   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files         500      500           
  Lines       22767    22767           
  Branches     5750     5728   -22     
=======================================
  Hits        12866    12866           
+ Misses       8696     8679   -17     
- Partials     1205     1222   +17
Flag Coverage Δ
taro-cli 75.00% <ø> (ø)
taro-runner 54.00% <25.00%> (ø)
taro-runtime 79.39% <ø> (ø)
taro-web 40.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/taro-mini-runner/src/webpack/chain.ts 74.61% <25.00%> (ø)

... and 21 files with indirect coverage changes

This was referenced Jun 22, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 22, 2024
Closed
Closed
@TechQuery
Copy link

解决这个问题：#15919

@VaynePeng 你直接重新编辑你的主题帖，在 fix # 后面写 issue 号码。

@VaynePeng VaynePeng changed the title fix: 修复 windows 路径问题 fix #15919 Jun 27, 2024
This was referenced Jun 29, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

windows 环境下 path 拼接未使用 path.join 导致返回的路径异常
3 participants
@VaynePeng @TechQuery @yoyo837