Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async void to be async Task everywhere #397

Open
Deadpikle opened this issue Nov 18, 2022 · 3 comments
Open

Fix async void to be async Task everywhere #397

Deadpikle opened this issue Nov 18, 2022 · 3 comments
Labels
enhancement
Milestone
3.x

Comments

@Deadpikle
Copy link
Collaborator

Shouldn't have async void anywhere as it hampers others calling the appropriate func and it's not...well, good code.
@Deadpikle Deadpikle added this to the 3.x milestone Nov 18, 2022
@smty2018
Copy link

@Deadpikle is this issue still open? Can i please give a try at this?

@Deadpikle
Copy link
Collaborator Author

@Deadpikle is this issue still open? Can i please give a try at this?

Yup!

smty2018 added a commit to smty2018/NetSparkle that referenced this issue Oct 16, 2023
@smty2018
Fix async void to be async Task everywhere NetSparkleUpdater#397
5bdaa2e
@smty2018 smty2018 mentioned this issue Oct 16, 2023
Closed
@smty2018
Copy link

@Deadpikle is this issue still open? Can i please give a try at this?

Yup!

@Deadpikle made a PR for this, can you please review

@SiMet SiMet mentioned this issue Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
2 participants
@Deadpikle @smty2018