Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownloadHadError hook is not working in Windows Operating system #616

Open
balaji222528 opened this issue Sep 9, 2024 · 3 comments
Open

Comments

@balaji222528
Copy link

DownloadHadError event is not working and not triggering in windows operating system when there is no connectivity etc.
But this is working in MAC which is quite wierd.

@Deadpikle Deadpikle added this to the 3.x milestone Sep 9, 2024
@Deadpikle
Copy link
Collaborator

Deadpikle commented Sep 11, 2024

Hi @balaji222528,

Thanks for your report. I appreciate it.

Just to be clear, what version of the library are you using on Windows, and what version of .NET are you using?

Thanks!

@balaji222528
Copy link
Author

Iam using .net 8 and netsparkle 2.3.0

@Deadpikle
Copy link
Collaborator

@balaji222528

On 2.3.0:

The docs for this event say, Called when the download of an app cast file **has downloaded** but has an error other than corruption (emphasis mine). In other words, if the app cast file never downloads, this event is not guaranteed to be called.

This event is not meant to be triggered when there is no download at all. Furthermore, I cannot replicate the DownloadHadError event being called on 2.3.0 on macOS.

If you are getting here through a call to CheckForUpdatesQuietly, monitor the UpdateCheckFinished event. The status will be UpdateStatus.CouldNotDetermine if the download failed outright.

If you are getting here through a call to CheckForUpdatesAtUserRequest, UIFactory?.ShowCannotDownloadAppcast is called.

If this does not help, please upload a reproducible sample.

Thanks!

@Deadpikle Deadpikle removed this from the 3.x milestone Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants