Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 9 unit tests, building #626

Merged
merged 19 commits into from
Nov 5, 2024
Merged

Add .NET 9 unit tests, building #626

merged 19 commits into from
Nov 5, 2024

Conversation

Deadpikle
Copy link
Collaborator

Totally untested.

@Deadpikle Deadpikle added this to the 3.x milestone Oct 10, 2024
@Deadpikle Deadpikle marked this pull request as draft October 10, 2024 10:01
@Deadpikle
Copy link
Collaborator Author

Deadpikle commented Oct 10, 2024

Looks like tests are failing on .NET 9 and not earlier versions, so there's been some sort of breaking change/fix that we'll need to handle.

Should also see about fixing some of the warnings that are coming up.

Need to push out a new version of Chaos.NaCl with .NET 9 compat too. It builds and tests just fine.

@Deadpikle
Copy link
Collaborator Author

Now passing tests on all platforms but failing to build on Windows

@Deadpikle
Copy link
Collaborator Author

Deadpikle commented Nov 5, 2024

@Deadpikle Deadpikle marked this pull request as ready for review November 5, 2024 09:36
@Deadpikle Deadpikle merged commit 1452374 into develop Nov 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant