Skip to content
This repository has been archived by the owner on Oct 31, 2018. It is now read-only.

Support killing tasks #4

Open
kayousterhout opened this issue Jan 22, 2015 · 0 comments
Open

Support killing tasks #4

kayousterhout opened this issue Jan 22, 2015 · 0 comments

Comments

@kayousterhout
Copy link
Member

The commit to add support for network and compute monotasks removes support for killing tasks on the executor. This should be added back by communicating relevant information to the LocalDagScheduler, which can avoid executing any new monotasks for the macrotask (and ideally interrupt any running monotasks for the macrotask).

Once we fix this issue, we should be able to fix some residual issues with the unit tests where, when a given unit test is running, sometimes there are old monotasks from previous unit tests still running, causing some weird failures (this should allow us to, in LocalDagScheduler, fail rather than just logging a warning when a monotask that's about to be run isn't in waitingMonotasks).

Once this is done, re-enable the "job group with interruption" test in JobCancellationSuite.scala. This should also significantly speed up the rest of the tests in JobCancellationSuite, which currently take a long time because they wait for tasks to finish executing rather than interrupting the tasks partway through execution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant