Enable round-tripping unsupported types #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
commented
May 27, 2021
| public override bool EqualsExact(Geometry other, double tolerance) => throw Unsupported(); | ||
| public override bool EqualsTopologically(Geometry g) => throw Unsupported(); | ||
| public override Geometry GetGeometryN(int n) => throw Unsupported(); | ||
| public override int GetHashCode() => throw Unsupported(); |
There was a problem hiding this comment.
😈 This and Equals probably breaks EF Core. We need to refine this a bit. I also haven't tested the experience with other parts of NTS.
bricelam
commented
May 27, 2021
Comment on lines
+241
to
+245
| case OpenGisType.CircularString: | ||
| case OpenGisType.CompoundCurve: | ||
| case OpenGisType.CurvePolygon: | ||
| case OpenGisType.FullGlobe: | ||
| return new UnsupportedGeometry(shape.Type, geography); |
There was a problem hiding this comment.
Note, if a GeometryCollection contains one of these, the whole collection will be returned as unsupported. A slightly better solution might be to return a GeometryCollection containing an UnsupportedGeometry.
|
I added a comment to the original issue regarding whether UnsupportedGeometry should be public instead of internal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #18
/cc @ajcvickers @JeremyLikness