Skip to content

Commit d457784

Browse files
committed
Small cleanup and clarification on README
1 parent c7c47db commit d457784

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎README.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@
1010

1111
Validates that FileVault content packages contain only Javascript files inside Client-Side libraries which can be minified without issues according to their (or the default) [minification configuration][clientlibs-jsprocessor].
1212

13-
It doesn't validate CSS files but only JS files. Also it only supports the processor with name `gcc` (backed by [Google Closure Compiler][google-closure-compiler]) but no longer the deprecated `yui` (backed by [YUI Compressor](yui-compressor)).
13+
It doesn't validate CSS files but only JS files. Also it only supports the processor with name `gcc` (backed by [Google Closure Compiler][google-closure-compiler]) but no longer the deprecated `yui` (backed by [YUI Compressor][yui-compressor]).
14+
15+
This validation is currently not performed by [aemanalyser-maven-plugin][aemanalyser-maven-plugin-issue].
1416

1517
## Implementation
1618

@@ -102,7 +104,7 @@ You can use this validator with the [FileVault Package Maven Plugin][filevault-p
102104

103105
Adobe, and AEM are either registered trademarks or trademarks of Adobe in the United States and/or other countries.
104106

105-
[aemanalyser-maven-plugin]: https://github.com/adobe/aemanalyser-maven-plugin/tree/main/aemanalyser-maven-plugin
107+
[aemanalyser-maven-plugin-issue]: https://github.com/adobe/aemanalyser-maven-plugin/issues/418
106108
[filevault-validation]: https://jackrabbit.apache.org/filevault/validation.html
107109
[filevault-p-m-p]: https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html
108110
[clientlibs-jsprocessor]: https://experienceleague.adobe.com/en/docs/experience-manager-cloud-service/content/implementing/developing/full-stack/clientlibs#using-preprocessors

‎src/main/java/biz/netcentric/filevault/validator/aem/clientlibrary/ClientLibraryJsProcessorValidator.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ private String getNodePathFromFilePath(Path filePath) {
203203
filePath.iterator().forEachRemaining(pathElement -> {
204204
platformPathBuilder.append("/").append(pathElement.toString());
205205
});
206-
// String platformPath = FilenameUtils.separatorsToUnix(filePath.toString());
206+
// platform path must have forward slashes as separators
207207
return PlatformNameFormat.getRepositoryPath(platformPathBuilder.toString(), true);
208208
}
209209

0 commit comments

Comments
 (0)