Skip to content

Commit c8d9cf2

Browse files
Bart Van Asscheaxboe
Bart Van Assche
authored andcommitted
block: Change argument type of scsi_req_init()
Since scsi_req_init() works on a struct scsi_request, change the argument type into struct scsi_request *. Signed-off-by: Bart Van Assche <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Reviewed-by: Martin K. Petersen <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent ca18d6f commit c8d9cf2

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

Diff for: block/scsi_ioctl.c

+7-3
Original file line numberDiff line numberDiff line change
@@ -741,10 +741,14 @@ int scsi_cmd_blk_ioctl(struct block_device *bd, fmode_t mode,
741741
}
742742
EXPORT_SYMBOL(scsi_cmd_blk_ioctl);
743743

744-
void scsi_req_init(struct request *rq)
744+
/**
745+
* scsi_req_init - initialize certain fields of a scsi_request structure
746+
* @req: Pointer to a scsi_request structure.
747+
* Initializes .__cmd[], .cmd, .cmd_len and .sense_len but no other members
748+
* of struct scsi_request.
749+
*/
750+
void scsi_req_init(struct scsi_request *req)
745751
{
746-
struct scsi_request *req = scsi_req(rq);
747-
748752
memset(req->__cmd, 0, sizeof(req->__cmd));
749753
req->cmd = req->__cmd;
750754
req->cmd_len = BLK_MAX_CDB;

Diff for: drivers/ide/ide-atapi.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ void ide_prep_sense(ide_drive_t *drive, struct request *rq)
199199
memset(sense, 0, sizeof(*sense));
200200

201201
blk_rq_init(rq->q, sense_rq);
202-
scsi_req_init(sense_rq);
202+
scsi_req_init(req);
203203

204204
err = blk_rq_map_kern(drive->queue, sense_rq, sense, sense_len,
205205
GFP_NOIO);

Diff for: drivers/ide/ide-probe.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -745,7 +745,7 @@ static void ide_initialize_rq(struct request *rq)
745745
{
746746
struct ide_request *req = blk_mq_rq_to_pdu(rq);
747747

748-
scsi_req_init(rq);
748+
scsi_req_init(&req->sreq);
749749
req->sreq.sense = req->sense;
750750
}
751751

Diff for: drivers/scsi/scsi_lib.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -1123,7 +1123,9 @@ EXPORT_SYMBOL(scsi_init_io);
11231123
*/
11241124
void scsi_initialize_rq(struct request *rq)
11251125
{
1126-
scsi_req_init(rq);
1126+
struct scsi_cmnd *cmd = blk_mq_rq_to_pdu(rq);
1127+
1128+
scsi_req_init(&cmd->req);
11271129
}
11281130
EXPORT_SYMBOL(scsi_initialize_rq);
11291131

Diff for: include/scsi/scsi_request.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ static inline void scsi_req_free_cmd(struct scsi_request *req)
2727
kfree(req->cmd);
2828
}
2929

30-
void scsi_req_init(struct request *);
30+
void scsi_req_init(struct scsi_request *req);
3131

3232
#endif /* _SCSI_SCSI_REQUEST_H */

0 commit comments

Comments
 (0)