Skip to content
This repository has been archived by the owner on Aug 31, 2018. It is now read-only.

Sorry but get disappointed to see this level of coding in NetFlix. #18

Open
ocdogan opened this issue Oct 3, 2015 · 2 comments
Open

Comments

@ocdogan
Copy link

ocdogan commented Oct 3, 2015

In "Fido/Director/Director_Helper/The_Director_HostDetection.cs" source the line "if ((sHostname == null) && (sHostname == String.Empty))" in "HostDetection" method is buggy, the case is impossible to succeed.

Find one to review this project's codes. There are many bugs.

Leave using email as the error logger and find a cleaver way. Also leave using "Console" as the main trace environment.

@pcluddite
Copy link

Not sure why they just didn't use String.IsNullOrEmpty(), especially considering they use it several times throughout that file anyway.

@dakre18
Copy link

dakre18 commented Feb 16, 2016

Both of you should really read the comments from Robfry at #16. If you checked that, you would see his response to why there are many bugs, the issues with licensing (i pointed out already it was copied from the stack overflow question), the lack of progress, and also his plans. Simple answer, he's working on it, but this is just a prototype.

Nothing bad about being worried or wanting to point out the problems with it, but this is most likely just scraps of code from all over. If it was working code, everyone would be worried, and if Netflix was using all of that code, I don't think they could use it. Just have to wait for the progress to start, and check back later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants