Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectator Id - ignore tags with empty or null value #582

Open
venki-netflix opened this issue Jun 29, 2018 · 0 comments
Open

spectator Id - ignore tags with empty or null value #582

venki-netflix opened this issue Jun 29, 2018 · 0 comments
Milestone

Comments

@venki-netflix
Copy link

venki-netflix commented Jun 29, 2018

Currently it looks like we dont log the counter if the value of a tag is either null or empty value. This behavior of quietly dropping the counter is not noticeable and can have missing counters.

It will be nice to ignore the tags that are empty and still log other tags.

with following style of coding its easy to have null or empty tag values.
id.withTag("tag1", tag1Value).withTag("tag2",tag2Value).withTag("tag3", tag3Value);
registry.counter(id).increment();

basically {"name":"foo", "app":"", "action:"abc"} will be same as {"name":"foo", "action:"abc"}

@brharrington brharrington added this to the backlog milestone Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants