Skip to content

Commit d3ff578

Browse files
authored
Reduce number of allocations in p2p (#2388)
1 parent 05b20ac commit d3ff578

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

p2p/sync/client.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ func requestAndReceiveStream[ReqT proto.Message, ResT proto.Message](ctx context
8282
}
8383
}()
8484

85+
var zero ResT
86+
res := zero.ProtoReflect().New().Interface()
8587
for {
86-
var zero ResT
87-
res := zero.ProtoReflect().New().Interface()
8888
if err := receiveInto(stream, res); err != nil {
8989
if !errors.Is(err, io.EOF) {
9090
log.Debugw("Error while reading from stream", "err", err)
@@ -96,6 +96,8 @@ func requestAndReceiveStream[ReqT proto.Message, ResT proto.Message](ctx context
9696
if !yield(res.(ResT)) {
9797
break
9898
}
99+
100+
proto.Reset(res)
99101
}
100102
}, nil
101103
}

0 commit comments

Comments
 (0)