Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State unavailability handling for DebugRpcModule #8178

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardgreg
Copy link
Contributor

Fixes #8174

Changes

  • Added try-catch blocks in both debug_traceTransaction and debug_traceCall to handle MissingTrieNodeException
  • Created the helper method GetStateFailureResult<T>() to standardize error messages for state unavailability
  • Matched error handling approaches with EthRpcModule and TraceRpcModule

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the state in this way:
https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs#L88

Use HasStateForBlock method like in trace module

@LukaszRozmej LukaszRozmej marked this pull request as draft February 13, 2025 07:36
@richardgreg richardgreg force-pushed the fix/8174-debug-hasstate-for-block branch from 8bce779 to 1d80f16 Compare February 22, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HasStateForBlock in debug module
2 participants