Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Goerli remnants #8182

Open
MarekM25 opened this issue Feb 9, 2025 · 8 comments · May be fixed by #8222
Open

Remove Goerli remnants #8182

MarekM25 opened this issue Feb 9, 2025 · 8 comments · May be fixed by #8222
Labels
good first issue

Comments

@MarekM25
Copy link
Contributor

MarekM25 commented Feb 9, 2025

Goerli doesn't exist but we have remnants in the code. Remove it. Whenever, BlockchainIds.Goerli is used in tests change it to Holesky or Sepolia
Image
@TobieTom
Copy link

Is this issue still available? Im new in the space and looking to add on to my experience. Thanks in advance

@enyinnaya1234
Copy link

Could I take over this issue?

@rahulsingh3526
Copy link

I would like to take this issue

@franz-ops
Copy link

Could I solve this?

@IshaanXCoder
Copy link

I'd love to solve this issue, pls assign this to me

@MarekM25
Copy link
Contributor Author

Nethermind is open source software - please propose PR if you know how to do it ;)

@Antrikshgwal
Copy link

Hey @MarekM25
Do i have to remove the whole GoerliSpecProvider.cs file too?

@Antrikshgwal Antrikshgwal linked a pull request Feb 18, 2025 that will close this issue
Draft
4 tasks
@MarekM25
Copy link
Contributor Author

yes, and remove BlockchainIds.Goerli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced BlockchainIds.Goerli to BlockchainIds.Sepolia in tests Antrikshgwal/nethermind
7 participants
@MarekM25 @franz-ops @IshaanXCoder @enyinnaya1234 @rahulsingh3526 @TobieTom @Antrikshgwal