Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motd's protocol should be i32 #62

Open
theaddonn opened this issue Apr 27, 2024 · 2 comments
Open

Motd's protocol should be i32 #62

theaddonn opened this issue Apr 27, 2024 · 2 comments
Labels
Bug Something isn't working

Comments

@theaddonn
Copy link

The Motd struct represents the protocol version as an u16, but the protocol version (for mcbe at least) is always represented as an i32.
(I don't know why it is a signed integer, lets hope protocol version -42 is planned)

Due to the raknet docs not defining the motd and mojang rather doing their own stuff in this area, this is a bug of consistency.

@theaddonn theaddonn added the Bug Something isn't working label Apr 27, 2024
@john-bv
Copy link
Member

john-bv commented Apr 27, 2024

A u16 was used here cause theoretically the number only goes up and will never exceed 65535 versions, but I guess we could change this for the sake of consistency.

@theaddonn
Copy link
Author

this is rather "for the sake of consistency" like you mentioned. And I am certainly sure we will get protocol version -42 one day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants