Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sedml fixes for biosimulations #115

Merged
merged 4 commits into from
Apr 18, 2024
Merged

sedml fixes for biosimulations #115

merged 4 commits into from
Apr 18, 2024

Conversation

sanjayankur31
Copy link
Member

fixes #114

@sanjayankur31 sanjayankur31 linked an issue Apr 18, 2024 that may be closed by this pull request
@sanjayankur31
Copy link
Member Author

Seems to work:
LEMS_NML2_Ex5_DetCell.sedml.txt

Otherwise biosimulations errors;

```
Multiple objects have the following ids:\n      -
hhpop_0_bioPhys1_membraneProperties_KConductances_KConductance_n_q\n
- hhpop_0_bioPhys1_membraneProperties_NaConductances_NaConductance_h_q\n
  -
  hhpop_0_bioPhys1_membraneProperties_NaConductances_NaConductance_m_q\n
  - hhpop_0_v\n      - time""
```
Otherwise biosimulations errs with:

```
Multiple objects have the following ids:\n      - time
```
@sanjayankur31 sanjayankur31 changed the title fix(sedml): sanitise report id in sedml export sedml fixes for biosimulations Apr 18, 2024
@pgleeson pgleeson merged commit 62cfdc8 into development Apr 18, 2024
15 checks passed
@sanjayankur31 sanjayankur31 deleted the feat/sed-ml-id-fix branch April 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug] sed-ml export: id attribute of report needs cleaning
2 participants