Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings about missing files of model during visualisation #315

Open
lej0hn opened this issue Mar 8, 2024 · 1 comment
Open

Add warnings about missing files of model during visualisation #315

lej0hn opened this issue Mar 8, 2024 · 1 comment
Labels
T: enhancement Type: enhancement

Comments

@lej0hn
Copy link
Contributor

lej0hn commented Mar 8, 2024

When visualising a model, it is possible to produce an incorrect visualisation while not all model files are present without any relevant warning or error.

Describe the solution you'd like
Add warning in the output logs of the visualisation in case of missing files. Maybe the files could be validated before the visualisation process and some corresponding warnings could be produced.

@sanjayankur31 sanjayankur31 added the T: enhancement Type: enhancement label Mar 10, 2024
@lej0hn
Copy link
Contributor Author

lej0hn commented Mar 14, 2024

Upon reading a neuroml file there is a boolean includes_include that when True, the included files are validated and if there is a missing file a critical log occurs and the process exits. Would it be a good solution to let the validation happen always, but then, it can be decided with another boolean to whether exit the process or just log a warning for the missing file upon finding one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: enhancement Type: enhancement
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants