Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /tutorials/W3D3_OptimalControl/instructor/W3D3_Tutorial1.html #16

Open
Alxec opened this issue Jul 28, 2023 · 2 comments
Open

Comments

@Alxec
Copy link

Alxec commented Jul 28, 2023

In Tutorial 1 on W3D3 (Optimal Control) there is an issue with the code for Interactive Demo 4.

It sets the params as params = [stay_prob, high_rew_p, low_rew_p, threshold] while the function "binaryHMM_belief" unpacks those params in different order: p_stay, low_rew_p, high_rew_p, threshold = self.params

The code should be as this: params = [stay_prob, low_rew_p, high_rew_p, threshold]

@iamzoltan
Copy link
Contributor

was this addressed?

@Alxec
Copy link
Author

Alxec commented Jun 18, 2024

was this addressed?

Doesn't look like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants