lint and fix

Author: NewbMiao

.golangci.yml

@@ -0,0 +1,71 @@
+run:
+  timeout: 30s
+  tests: true
+  allow-parallel-runners: true
+issues:
+  exclude:
+    - abcdef
+exclude-use-default: false
+linters:
+  disable-all: true
+  enable:
+    - bodyclose
+    - depguard
+    - dogsled
+    - dupl
+    - errcheck
+    - exhaustive
+    - goconst
+    - gocritic
+    - gocyclo
+    - gofmt
+    - goimports
+    - goprintffuncname
+    - gosec
+    - gosimple
+    - govet
+    - ineffassign
+    - interfacer
+    - lll
+    - misspell
+    - nakedret
+    - noctx
+    - nolintlint
+    - rowserrcheck
+    - scopelint
+    - staticcheck
+    - structcheck
+    - typecheck
+    - unconvert
+    - varcheck
+    - whitespace
+    - asciicheck
+    - godox
+    - maligned
+    - prealloc
+    - golint
+#    - unparam
+#    - stylecheck
+#    - nestif
+#    - goerr113
+#    - gomnd
+#    - unused
+#    - testpackage
+#    - deadcode
+#    - wsl
+#    - gochecknoglobals
+#    - gocognit
+#    - godot
+#    - funlen
+#    - gochecknoinits
+
+linters-settings:
+  gocritic:
+    disabled-checks:
+      - ifElseChain
+      - captLocal
+      - appendAssign
+  lll:
+    line-length: 150
+  golint:
+    min-confidence: 0.8

array/partitionArray.go

@@ -1,6 +1,6 @@
 package array
 
-//将有序数组无重复部分移到左侧
+//将有序数组无重复部分移到左侧.
 func leftUnique(arr []int) {
 	l := len(arr)
 	if l <= 1 {

array/partitionArray_test.go

@@ -1,8 +1,8 @@
 package array
 
 import (
-	"testing"
 	"fmt"
+	"testing"
 )
 
 func TestLeftUnique(t *testing.T) {
@@ -17,8 +17,8 @@ func TestLeftUnique(t *testing.T) {
 	}
 }
 
-func TestSort(t *testing.T)  {
-	d:=[]int{ 2, 1, 2, 0, 1, 1, 2, 2, 0 }
+func TestSort(t *testing.T) {
+	d := []int{2, 1, 2, 0, 1, 1, 2, 2, 0}
 	want := []int{0, 0, 1, 1, 1, 2, 2, 2, 2}
 	t.Log(fmt.Sprintf("partitionArray_sort, input list %v, want: %v", d, want))
 	pSort(d)

array/subarray/maxsubarray.go

@@ -16,7 +16,7 @@ func MaxSubArraySum(d []int, target int) (res []int) {
 
 		//若差值存在于sumMap，则返回（from+1,i）子数组
 		if from, ok := sumMap[preSum]; ok {
-			return d[from+1:i+1]
+			return d[from+1 : i+1]
 		}
 	}
 	return

array/subarray/maxsubarray_test.go

@@ -1,8 +1,8 @@
 package subarray
 
 import (
-	"testing"
 	"fmt"
+	"testing"
 )
 
 func TestMaxSubArraySum(t *testing.T) {

array/sumArr.go

@@ -4,7 +4,7 @@ import (
 	"sort"
 )
 
-//获取arr中和为sum的所有子数组
+//获取arr中和为sum的所有子数组.
 func FindSumArr(arr []int, sum int) (sub [][]int) {
 	sort.Ints(arr)                         //升序arr
 	index := len(arr) - 1                  //倒着计算子数组

array/sumArr_test.go

@@ -1,22 +1,22 @@
 package array
 
 import (
-	"testing"
 	"fmt"
+	"testing"
 )
 
 func TestSumArr(t *testing.T) {
-	arr := []int{1, 10, 4, 22, 5, 6,}
+	arr := []int{1, 10, 4, 22, 5, 6}
 	sum := 20
 	r := FindSumArr(arr, sum)
 	t.Log(fmt.Sprintf("SumArr, input arr :%v, want subArray which sum is %d : %v", arr, sum, r))
 
 	/*
-	output:
-		10,6,4
-		10,5,4,1
-		8,7,5
-		8,7,4,1
-		8,6,5,1
+		output:
+			10,6,4
+			10,5,4,1
+			8,7,5
+			8,7,4,1
+			8,6,5,1
 	*/
 }

batchTest.sh

@@ -1,6 +1,6 @@
 package binary
 
-//一组整型数据，这些数据中，其中有一个数只出现了一次，其他的数都出现了两次，找出出现一次的数
+//一组整型数据，这些数据中，其中有一个数只出现了一次，其他的数都出现了两次，找出出现一次的数.
 func getNoRepeatNum(arr []int) (repeatNum int) {
 	for _, v := range arr {
 		repeatNum ^= v

binary/array.go

@@ -1,8 +1,8 @@
 package binary
 
 import (
-	"testing"
 	"fmt"
+	"testing"
 )
 
 func TestGetNoRepeatNum(t *testing.T) {

binary/array_test.go

@@ -1,6 +1,6 @@
 package binary
 
-//x & ~0 = x;	x & 0 = 0
+//x & ~0 = x;	x & 0 = 0.
 func Min(x, y int) (r int) {
 	var less int
 	if x < y {

binary/math.go

@@ -1,8 +1,8 @@
 package binary
 
 import (
-	"testing"
 	"fmt"
+	"testing"
 )
 
 func TestMin(t *testing.T) {
@@ -40,15 +40,14 @@ func TestIsPowerOf2(t *testing.T) {
 	}
 }
 
-
 func TestMPowerOfN(t *testing.T) {
-	var m,n = 5,6
+	var m, n = 5, 6
 	var want = 15625
-	t.Log(fmt.Sprintf("input: %d power of %d? want: %d", m,n, want))
+	t.Log(fmt.Sprintf("input: %d power of %d? want: %d", m, n, want))
 
-	if mPowerOfN(m,n) == want {
+	if mPowerOfN(m, n) == want {
 		t.Log("mPowerOfN is ok")
 	} else {
-		t.Error("mPowerOfN is not ok, get:",mPowerOfN(m,n))
+		t.Error("mPowerOfN is not ok, get:", mPowerOfN(m, n))
 	}
 }

binary/math_test.go

@@ -4,19 +4,19 @@ import "fmt"
 
 // http://graphics.stanford.edu/~seander/bithacks.html
 
-//平行计算,异或压缩奇偶信息，压缩顺序:1->2->4->8->16->32
+//平行计算,异或压缩奇偶信息，压缩顺序:1->2->4->8->16->32.
 func judgeBinOddOne1(x uint) bool {
 	const intSize = 32 << (^uint(0) >> 63)
 	var i uint = 1
 	for i < intSize {
-		x = x ^ (x >> i)
+		x ^= x >> i
 		i *= 2
 	}
 	return x&1 == 1
 }
 
 // 一个二进制数减1，若右起第一个1的索引位置是m，那么从m到0位的二进制会逐位取反。
-// 所以，x &= x-1会使得从m到0位的二进制都会变成0。
+// 所以，x &= x-1会使得从m到0位的二进制都会变成0。.
 func judgeBinOddOne2(x uint) bool {
 	cnt := 0
 	for x > 0 {
@@ -27,7 +27,7 @@ func judgeBinOddOne2(x uint) bool {
 	return cnt&1 == 1
 }
 
-//查表法：256区间内1的个数表
+//查表法：256区间内1的个数表.
 func judgeBinOddOne3(x uint) bool {
 	var bitmap256 = [256]int{0}
 	for i := 1; i < 256; i++ {
@@ -36,7 +36,7 @@ func judgeBinOddOne3(x uint) bool {
 	cnt := 0
 	for x != 0 {
 		cnt += bitmap256[x&0xff]
-		x = x >> 8
+		x >>= 8
 	}
 	fmt.Printf("judgeBinOddOne has one: %d\n", cnt)
 	return cnt&1 == 1
@@ -55,7 +55,7 @@ func judgeBinOddOne3(x uint) bool {
 // 就变成了16个段，每段2位。
 // 同理(n&0x33333333)+((n>>2)&0x33333333)将16个段中相邻的两个段两两相加，
 // 存放在4bits中，就变成了8个段，每段4位。
-// 以此类推，最终求得数中1的个数就存放在一个段中，这个段32bits，
+// 以此类推，最终求得数中1的个数就存放在一个段中，这个段32bits，.
 func judgeBinOddOne4(x uint) bool {
 	const intSize = 32 << (^uint(0) >> 63)
 	var bMap = map[int][]uint{
@@ -86,7 +86,7 @@ func judgeBinOddOne4(x uint) bool {
 func judgeBinOddOne5(x uint) bool {
 	//parity map
 	var pMap = make([]uint, 0)
-	var p2 = func(n uint) ([]uint) {
+	var p2 = func(n uint) []uint {
 		return []uint{n, n ^ 1, n ^ 1, n}
 	}
 	var p4 = func(n uint) (r []uint) {
@@ -119,12 +119,12 @@ func judgeBinOddOne5(x uint) bool {
 	var p uint = 0
 	for x != 0 {
 		p ^= pMap[x&0xff]
-		x = x >> 8
+		x >>= 8
 	}
 	return p == 1
 }
 
-//并行查奇偶表：0110 1001 1001 0110 (0x6996 in hex)
+//并行查奇偶表：0110 1001 1001 0110 (0x6996 in hex).
 func judgeBinOddOne6(x uint) bool {
 	const intSize = 32 << (^uint(0) >> 63)
 	if intSize == 64 {
@@ -137,7 +137,7 @@ func judgeBinOddOne6(x uint) bool {
 	return (0x6996>>x)&1 == 1
 }
 
-//multiple 8 operations
+//multiple 8 operations.
 func judgeBinOddOne7(x uint) bool {
 	const intSize = 32 << (^uint(0) >> 63)
 	iMap := map[int]uint{

binary/oddones.go

@@ -1,8 +1,8 @@
 package binary
 
 import (
-	"testing"
 	"fmt"
+	"testing"
 )
 
 func TestOddOnes(t *testing.T) {
@@ -25,5 +25,4 @@ func TestOddOnes(t *testing.T) {
 			t.Error(fmt.Sprintf("judgeBinOddOne%d is not ok", k+1))
 		}
 	}
-
 }

binary/oddones_test.go

@@ -20,7 +20,7 @@ func reverseBit1(x uint) (r uint) {
 func reverseBit2(x uint) (r uint) {
 	//reverse map
 	var rMap = make([]uint, 0)
-	var p2 = func(n uint) ([]uint) {
+	var p2 = func(n uint) []uint {
 		return []uint{n, n + 2*64, n + 1*64, n + 3*64}
 	}
 	var p4 = func(n uint) (r []uint) {
@@ -46,9 +46,9 @@ func reverseBit2(x uint) (r uint) {
 	intSize -= 8
 	for x != 0 {
 		r |= rMap[x&0xff] << intSize
-		x = x >> 8
+		x >>= 8
 	}
-	return
+	return r
 }
 
 func ReverseBin32(v uint32) (r uint32) {
@@ -59,7 +59,7 @@ func ReverseBin32(v uint32) (r uint32) {
 	s >>= 1
 	for s > 0 {
 		mask ^= (mask << s)
-		v = ((v >> s) & mask) | ((v << s) & (^mask));
+		v = ((v >> s) & mask) | ((v << s) & (^mask))
 		s >>= 1
 	}
 

binary/reverse.go

@@ -1,8 +1,8 @@
 package binary
 
 import (
-	"testing"
 	"fmt"
+	"testing"
 )
 
 func TestReverse(t *testing.T) {
@@ -31,5 +31,4 @@ func TestReverse(t *testing.T) {
 			t.Error(fmt.Sprintf("reverseBit%d is not ok", k+1), v, fmt.Sprintf("(%b)", v))
 		}
 	}
-
 }

binary/reverse_test.go

@@ -1,8 +1,8 @@
 package binary
 
-//交换二进制指定区间 (i+n-1~i) 和 （j+n-1~j）
+//交换二进制指定区间 (i+n-1~i) 和 （j+n-1~j）.
 func swapBitSeq(i, j, n, b uint) (r uint) {
 	x := (b>>i ^ b>>j) & (1<<n - 1)
 	r = b ^ (x<<i | x<<j)
 	return
-}
+}

binary/swap.go

@@ -1,8 +1,8 @@
 package binary
 
 import (
-	"testing"
 	"fmt"
+	"testing"
 )
 
 func TestSwap(t *testing.T) {