Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Theme 테스트코드 작성 및 API 구현 #17

Merged
merged 5 commits into from
Jul 16, 2023
Merged

[FEAT] Theme 테스트코드 작성 및 API 구현 #17

merged 5 commits into from
Jul 16, 2023

Conversation

eunsol-an
Copy link
Member

PR 타입

  • 기능 추가

반영 브랜치

feature/theme → develop

작업 사항

  • controller, service, repository 별 유닛 테스트를 작성하였습니다.
  • 테마 등록/조회 API를 구현하였고, 수정/삭제는 추가 작업이 필요합니다.
  • 프로젝트/패키지명을 o-escape로 변경하였습니다.
  • 현재 진행 중인 프로젝트와의 변경 지점을 줄이기 위해 부득이하게 작업 중 Merge 요청 합니다.

체크리스트

  • 빌드에 성공했나요?
  • 코드 컨벤션을 잘 지켰나요? (cmd + opt + L)

테스트 결과

API 테스트는 아직 진행하지 못했습니다. 추후 postman 테스트 예정입니다.

@eunsol-an eunsol-an added the ✨feature New feature or request label Jul 16, 2023
@eunsol-an eunsol-an requested a review from delphox60 July 16, 2023 15:53
@eunsol-an eunsol-an self-assigned this Jul 16, 2023
@eunsol-an eunsol-an linked an issue Jul 16, 2023 that may be closed by this pull request
테마 테스트 코드 작성 #2
Open
3 tasks
@delphox60
Copy link
Collaborator

늦게까지 고생많으십니다~! 파이팅 🔥🔥

delphox60
delphox60 approved these changes Jul 16, 2023
View reviewed changes
Copy link
Collaborator

@delphox60 delphox60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜로 수고 많으셨습니다 🙏

@eunsol-an eunsol-an merged commit 7b63aec into develop Jul 16, 2023
@eunsol-an eunsol-an deleted the feature/theme branch July 16, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delphox60 delphox60 delphox60 approved these changes

Assignees

@eunsol-an eunsol-an

Labels
✨feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

테마 테스트 코드 작성
2 participants
@eunsol-an @delphox60