Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default view shows transactions created at the current date instead of the transactions of the day #746

Open
Braayy opened this issue Dec 3, 2023 · 5 comments · May be fixed by #784
Open
Labels
help wanted Extra attention is needed
Milestone

Comments

@Braayy
Copy link

Braayy commented Dec 3, 2023

Explanation

Hi! I don't know if this is intended, but when i create a transaction with a different date than today, the default view still shows the just created transaction. I think the reason is because the view queries all transaction with the creation date or transaction date equal to today, instead of just the ones with the transaction date equal to today.

Example

Here i create a transaction with date 2023/12/04.
Captura de tela de 2023-12-02 22-15-58

And the view, shows the just created transaction, even if the transaction date is 2023/12/04. The day when i took the screenshot was 2023/12/02.
Captura de tela de 2023-12-02 22-16-36

I then created another transaction with the today date in it, just to show that my assumption, that the view shows all transactions with creation date or transaction date equal to today, is true.
Captura de tela de 2023-12-02 22-17-06

If i click on the calendar on 2023/12/04, it only shows the Testing transaction and not Testing 2 transaction.

Conclusion

If this is intended, it could be helpful to add an configuration to disable this behavior, as it is a little annoying for me at least.

If this isn't intended, i could try to create a pr for solving this issue.

Thanks in advance

@JoseBritto
Copy link
Member

Thanks for the detailed report! Currently Denaro treats selecting current date as if no date is selected. This isn't ideal, and I'm not sure how to go about fixing this. Currently @nlogozzo is a bit busy, he is the one who can tackle this issue.

My suggestion is maybe have the Today button be called "Reset" or something similar, which shows all transactions without any date filter and select the current month on the calendar view instead of the current day. I'm not sure how to do this, I tried calling this method but got stuck as I don't know how to do to convert Int32 to guint. After we have this then we can treat selecting the current day as any other date and by default on app startup we can have no date selected and show all transactions. This should hopefully solve this problem.

@nlogozzo
Copy link
Member

Currently Denaro treats selecting current date as if no date is selected. This isn't ideal, and I'm not sure how to go about fixing this.

The reason for this is because the Calendar has no way of "unselecting" a date, that is a date is always selected in the Calendar. Therefore, we made the decision when we first made the app to have today's date be kind of a "Today" overview of all of your transactions in your account and then when you select a different date in the calendar it will actually filter the transactions on those dates.

One thing you could do is sort by decreasing day to have today's transactions always show up at the top of the list.

But like @JoseBritto said, I don't know of a better design for this.

I'm not sure how to do this, I tried calling this method but got stuck as I don't know how to do to convert Int32 to guint.

The problem with this method is it will change the selected month, but the day will still be highlighted/selected since like I said above, the calendar cannot have no dates selected.

@JoseBritto
Copy link
Member

The problem with this method is it will change the selected month, but the day will still be highlighted/selected since like I said above, the calendar cannot have no dates selected.

Ah. I didn't know that

@nlogozzo
Copy link
Member

Yeah so I don't really know how to solve this without a rework of the ui/controls used.

@nlogozzo nlogozzo added the help wanted Extra attention is needed label Feb 2, 2024
@nlogozzo nlogozzo linked a pull request Apr 6, 2024 that will close this issue
7 tasks
@nlogozzo nlogozzo added this to the V2024.5.0 milestone Apr 6, 2024
@nlogozzo
Copy link
Member

nlogozzo commented Apr 6, 2024

The C++ rewrite is bringing a brand new design to the entire application. More to follow as we develop the new version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants