Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

175 complete ecdsa bbf #304

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

175 complete ecdsa bbf #304

wants to merge 8 commits into from
+2,347 −194

Conversation

AntoineCyr
Copy link
Contributor

@AntoineCyr AntoineCyr commented Jan 30, 2025 •
edited
Loading

Migrated 3 new circuits in bbf:

  • ec_two_t_plus_q
  • ec_scalar_mult
  • ecdsa_recovery

Normalizing imports and variables accros subcomponents

@AntoineCyr AntoineCyr self-assigned this Jan 30, 2025
@AntoineCyr AntoineCyr linked an issue Jan 30, 2025 that may be closed by this pull request
ECDSA in bbf #175
Open
@AntoineCyr AntoineCyr marked this pull request as draft January 30, 2025 21:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

Clang Test Results

  177 files  +3    177 suites  +3   22m 50s ⏱️ + 6m 35s
8 545 tests ±0  8 539 ✅ ±0  6 💤 ±0  0 ❌ ±0 
8 611 runs  ±0  8 605 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit cb80ead. ± Comparison against base commit 4580b49.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. 
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test

blueprint_plonk_test_suite ‑ blueprint_plonk_bbf_ec_scalar_mult_test
blueprint_plonk_test_suite ‑ blueprint_plonk_bbf_ec_two_t_plus_q_test
blueprint_plonk_test_suite ‑ blueprint_plonk_pubkey_non_native_ecdsa_pallas
blueprint_plonk_test_suite ‑ blueprint_plonk_pubkey_non_native_ecdsa_vesta

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Gcc Test Results

  176 files  +2    176 suites  +2   19m 36s ⏱️ + 2m 15s
8 547 tests +2  8 541 ✅ +2  6 💤 ±0  0 ❌ ±0 
8 613 runs  +2  8 607 ✅ +2  6 💤 ±0  0 ❌ ±0 

Results for commit 41ab935. ± Comparison against base commit 331cae7.

@AntoineCyr AntoineCyr force-pushed the 175-complete-ECDSA-bbf branch from bcb84ee to d06a946 Compare February 4, 2025 16:48
@AntoineCyr AntoineCyr marked this pull request as ready for review February 4, 2025 16:49
@AntoineCyr AntoineCyr force-pushed the 175-complete-ECDSA-bbf branch from d8c0bb6 to e815fb7 Compare February 5, 2025 16:21
@AntoineCyr AntoineCyr requested a review from ayashunsky February 5, 2025 17:02
@AntoineCyr AntoineCyr force-pushed the 175-complete-ECDSA-bbf branch from 258e5bc to 958c331 Compare February 6, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayashunsky ayashunsky Awaiting requested review from ayashunsky

At least 1 approving review is required to merge this pull request.

Assignees

@AntoineCyr AntoineCyr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECDSA in bbf
1 participant
@AntoineCyr