Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greatest Common Divisor Not working #2

Open
NirmalManoj opened this issue Jan 25, 2023 · 10 comments · May be fixed by #10, #17, #19, #32 or #36
Open

Greatest Common Divisor Not working #2

NirmalManoj opened this issue Jan 25, 2023 · 10 comments · May be fixed by #10, #17, #19, #32 or #36
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@NirmalManoj
Copy link
Owner

Describe the bug
When I use the gcd.py to find the greatest common divisor of two numbers, it is not giving the correct output. The output seems to be addition instead of finding gcd.

To Reproduce
Steps to reproduce the behavior:

  1. Run python gcd.py
  2. Give 23 and 10 as the two numbers
  3. The answer would be given as 33

Expected behavior
The answer should be 1.

Screenshots
image
@NirmalManoj NirmalManoj added bug Something isn't working good first issue Good for newcomers labels Jan 25, 2023
@Elie-Z Elie-Z mentioned this issue Jan 25, 2023
Open
4 tasks
@SivaPullaiah
Copy link

I would like work on this issue

@SivaPullaiah SivaPullaiah linked a pull request Feb 9, 2023 that will close this issue
Open
4 tasks
@anitha0405
Copy link

Shall I work on this?

@sunil-102002
Copy link

Fixed gcd#13

@srikanth-kandi srikanth-kandi linked a pull request Feb 10, 2023 that will close this issue
Open
4 tasks
@Bala-Magesh Bala-Magesh linked a pull request Feb 10, 2023 that will close this issue
Open
4 tasks
@jaswanthaitha21 jaswanthaitha21 mentioned this issue Feb 11, 2023
Open
4 tasks
@vkssrinivas vkssrinivas linked a pull request Feb 11, 2023 that will close this issue
Open
4 tasks
@himank004 himank004 linked a pull request Feb 12, 2023 that will close this issue
Open
4 tasks
@Rutvik-Pradyumna Rutvik-Pradyumna mentioned this issue Feb 14, 2023
Closed
@Hasinichaithanya Hasinichaithanya linked a pull request Feb 14, 2023 that will close this issue
Open
4 tasks
@PramodToleti PramodToleti linked a pull request Feb 14, 2023 that will close this issue
Open
4 tasks
@jeevitha46
Copy link

i would like to work on it

@sunil-102002
Copy link

sunil-102002 commented Feb 15, 2023 via email

@himanshu22500 himanshu22500 linked a pull request Feb 15, 2023 that will close this issue
Open
4 tasks
@sivaraju5609
Copy link

gcd great common divisor by doing with 10 we get finally 1 as out put

@jeevitha46
Copy link

gcd great common divisor by doing with 10 we get finally 1 as out put

ok

@meihu-ganesh meihu-ganesh mentioned this issue Feb 15, 2023
Open
4 tasks
@Hussain-Sharif Hussain-Sharif mentioned this issue Feb 15, 2023
Open
4 tasks
@rishithMinupala rishithMinupala linked a pull request Feb 16, 2023 that will close this issue
Open
4 tasks
@Harsha-484 Harsha-484 linked a pull request Feb 16, 2023 that will close this issue
Open
4 tasks
@AshReks AshReks mentioned this issue Feb 16, 2023
Closed
4 tasks
@Gnani-Codes Gnani-Codes linked a pull request Feb 16, 2023 that will close this issue
Open
4 tasks
@thenethi thenethi linked a pull request Feb 16, 2023 that will close this issue
Open
4 tasks
@harshithhdasari harshithhdasari linked a pull request Feb 17, 2023 that will close this issue
Open
4 tasks
@SAIMANIKESH SAIMANIKESH linked a pull request Feb 17, 2023 that will close this issue
Open
4 tasks
@bhavana-maheshwaram bhavana-maheshwaram linked a pull request Feb 17, 2023 that will close this issue
Open
4 tasks
@komalpasumarthy komalpasumarthy linked a pull request Feb 17, 2023 that will close this issue
Open
4 tasks
@PrincessTeddu
Copy link

PrincessTeddu commented Feb 18, 2023 •
edited
Loading

a) I have committed only those files that are required.
b) I have tried commit messages concise and reflective of the code committed.
c) I have used a branch name reflective of the issue.
d) If there is relevant issue for the PR, I have used closes # to auto-close the issue once PR is merged.

Detailed description

No function or code is there to calculate gcd , file was just adding values and printing, without making any calculations.

Test plan (required)

We can use any set of 2 positive numbers and it produces the right result.

Closing issues

closes #2

@vasundhra-jain vasundhra-jain linked a pull request Feb 18, 2023 that will close this issue
Open
4 tasks
@akashpadala akashpadala linked a pull request Feb 18, 2023 that will close this issue
Open
4 tasks
@Mudrakola Mudrakola linked a pull request Feb 18, 2023 that will close this issue
Open
@lrtraviteja lrtraviteja linked a pull request Feb 19, 2023 that will close this issue
Open
4 tasks
@Nis070 Nis070 mentioned this issue Feb 21, 2023
Closed
4 tasks
This was referenced Feb 25, 2023
Closed
Closed
@8pandemonium8 8pandemonium8 mentioned this issue Feb 25, 2023
Closed
4 tasks
@SaiChandra22 SaiChandra22 mentioned this issue Mar 1, 2023
Open
4 tasks
@manju7123 manju7123 linked a pull request Mar 4, 2023 that will close this issue
Open
4 tasks
@mrgsravanthi mrgsravanthi linked a pull request Mar 5, 2023 that will close this issue
Open
4 tasks
@Ajaychettamaina2004
Copy link

i would like to work on this

@PrincessTeddu
Copy link

PrincessTeddu commented Mar 19, 2023 via email

@PrasannaKumarBhursu PrasannaKumarBhursu linked a pull request Mar 20, 2023 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
8 participants
@NirmalManoj @SivaPullaiah @sivaraju5609 @sunil-102002 @anitha0405 @jeevitha46 @PrincessTeddu @Ajaychettamaina2004