Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space-opt-migration: Small fixes #110

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

robin-nitrokey
Copy link
Member

Some small fixes for #55. They should eventually be squashed into the parent commit but for transparency during the review, I wanted to keep and merge them separately.

  • We set total_credentials to Some(num_rks) just before accessing it, so we don’t need to go through the option.
  • prev_filename is always set to Some so we can remove the Option.
  • rp_dir is now always RK_DIR so we don’t need to cache it.

@robin-nitrokey robin-nitrokey merged commit 780baa1 into space-opt-migration Nov 4, 2024
@robin-nitrokey robin-nitrokey deleted the space-opt-migration-fixup branch November 4, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants