Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test application builds before deployment #177

Open
mmerklinger opened this issue Dec 1, 2023 · 0 comments
Open

Test application builds before deployment #177

mmerklinger opened this issue Dec 1, 2023 · 0 comments
Labels
cicd Improvements or additions to CICD dependencies Changes to dependencies feature New feature or request

Comments

@mmerklinger
Copy link
Collaborator

mmerklinger commented Dec 1, 2023 •
edited
Loading

The CI pipeline should test builds so that we not accidentally shipping broken builds.

The pyinstaller builds, creating one-directory and one-file builds for Linux/Windows, use the Poetry lock-file to pin the used version. The build for PyPI does not use the lock-file. Hence we can end up with an unexpected untested version, which can break the application without us noticing.
@mmerklinger mmerklinger added feature New feature or request cicd Improvements or additions to CICD dependencies Changes to dependencies labels Dec 1, 2023
@mmerklinger mmerklinger mentioned this issue Dec 1, 2023
Merged
@mmerklinger mmerklinger changed the title Verify application builds before deployment Test application builds before deployment Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cicd Improvements or additions to CICD dependencies Changes to dependencies feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmerklinger