Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If CTAP communication is corrupted nitrokey-app2 will not start #38

Open
daringer opened this issue Apr 11, 2023 · 0 comments
Open

If CTAP communication is corrupted nitrokey-app2 will not start #38

daringer opened this issue Apr 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@daringer
Copy link
Collaborator

(using the single binary linux version)

This is likely a rare case for the end-user, but a busy ctap channel can easily occur during development. The actual issue to solve here is to move the communication with the device into a separate thread to ensure that any errors during communication does not crash the entire app.

example output (directly after starting):

Traceback (most recent call last):
  File "nitrokeyapp/__main__.py", line 20, in <module>
  File "nitrokeyapp/__main__.py", line 16, in main
  File "nitrokeyapp/gui.py", line 149, in __init__
  File "nitrokeyapp/gui.py", line 290, in init_gui
  File "nitrokeyapp/gui.py", line 202, in detect_nk3
  File "pynitrokey/nk3/__init__.py", line 25, in list
  File "pynitrokey/nk3/device.py", line 146, in list
  File "pynitrokey/nk3/device.py", line 73, in __init__
  File "pynitrokey/nk3/admin_app.py", line 71, in status
  File "pynitrokey/nk3/admin_app.py", line 58, in _call
  File "pynitrokey/nk3/device.py", line 133, in _call
  File "fido2/hid/__init__.py", line 216, in call
fido2.ctap.CtapError: CTAP error: 0x06 - CHANNEL_BUSY
[1924370] Failed to execute script '__main__' due to unhandled exception!

@Niklap97 Niklap97 added the bug Something isn't working label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants