Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWS commands should return Slot not programmed error #56

Open
robinkrahl opened this issue Jan 16, 2019 · 0 comments
Open

PWS commands should return Slot not programmed error #56

robinkrahl opened this issue Jan 16, 2019 · 0 comments
Labels
bug
Milestone
v0.12

Comments

@robinkrahl
Copy link

When accessing a slot that has not been programmed, the PWS commands should return a Slot not programmed error instead of an empty string. (Same applies for the Nitrokey Storage.)
@szszszsz szszszsz mentioned this issue Jan 16, 2019
Open
robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Jan 25, 2019
@robinkrahl
Check PWS slot status before accessng it
f18abc4 
The Nitrokey devices to not check whether a PWS slot is programmed
before accessing it (upstream issues [0] [1]).  Until this is fixed in
the firmware, we have to manually check the slot status in nitrocli pws
get.  This could have been done in libnitrokey or the nitrokey crate,
yet this would lead to unnecessary commands if we check multiple fields
of a slot at the same time.

[0] Nitrokey/nitrokey-pro-firmware#56
[1] Nitrokey/nitrokey-storage-firmware#81
@robinkrahl robinkrahl mentioned this issue Jan 25, 2019
Closed
robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Jan 25, 2019
@robinkrahl
Check PWS slot status before accessng it
a3c8e6c 
The Nitrokey devices to not check whether a PWS slot is programmed
before accessing it (upstream issues [0] [1]).  Until this is fixed in
the firmware, we have to manually check the slot status in nitrocli pws
get.  This could have been done in libnitrokey or the nitrokey crate,
yet this would lead to unnecessary commands if we check multiple fields
of a slot at the same time.

[0] Nitrokey/nitrokey-pro-firmware#56
[1] Nitrokey/nitrokey-storage-firmware#81
robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Jan 25, 2019
@robinkrahl
Check PWS slot status before accessing it
411622a 
The Nitrokey devices to not check whether a PWS slot is programmed
before accessing it (upstream issues [0] [1]).  Until this is fixed in
the firmware, we have to manually check the slot status in nitrocli pws
get.  This could have been done in libnitrokey or the nitrokey crate,
yet this would lead to unnecessary commands if we check multiple fields
of a slot at the same time.

[0] Nitrokey/nitrokey-pro-firmware#56
[1] Nitrokey/nitrokey-storage-firmware#81
robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Jan 26, 2019
@robinkrahl
Check PWS slot status before accessing it
0499a1e 
The Nitrokey devices to not check whether a PWS slot is programmed
before accessing it (upstream issues [0] [1]).  Until this is fixed in
the firmware, we have to manually check the slot status in nitrocli pws
get.  This could have been done in libnitrokey or the nitrokey crate,
yet this would lead to unnecessary commands if we check multiple fields
of a slot at the same time.

[0] Nitrokey/nitrokey-pro-firmware#56
[1] Nitrokey/nitrokey-storage-firmware#81
robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Jan 26, 2019
@robinkrahl
Check PWS slot status before accessing it
f0e9a2a 
The Nitrokey devices to not check whether a PWS slot is programmed
before accessing it (upstream issues [0] [1]).  Until this is fixed in
the firmware, we have to manually check the slot status in nitrocli pws
get.  This could have been done in libnitrokey or the nitrokey crate,
yet this would lead to unnecessary commands if we check multiple fields
of a slot at the same time.

[0] Nitrokey/nitrokey-pro-firmware#56
[1] Nitrokey/nitrokey-storage-firmware#81
d-e-s-o pushed a commit to d-e-s-o/nitrocli that referenced this issue Jan 26, 2019
@robinkrahl @d-e-s-o
Check PWS slot status before accessing it
ebf29b1 
The Nitrokey devices do not check whether a PWS slot is programmed
before accessing it (upstream issues [0] [1]). Until this is fixed in
the firmware, we have to manually check the slot status in pws get. This
could have been done in libnitrokey or the nitrokey crate, yet this
would lead to unnecessary commands if we check multiple fields of a slot
at the same time.

[0] Nitrokey/nitrokey-pro-firmware#56
[1] Nitrokey/nitrokey-storage-firmware#81
d-e-s-o pushed a commit to d-e-s-o/nitrocli that referenced this issue Jan 26, 2019
@robinkrahl @d-e-s-o
Check PWS slot status before accessing it
ff14965 
The Nitrokey devices do not check whether a PWS slot is programmed
before accessing it (upstream issues [0] [1]). Until this is fixed in
the firmware, we have to manually check the slot status in pws get. This
could have been done in libnitrokey or the nitrokey crate, yet this
would lead to unnecessary commands if we check multiple fields of a slot
at the same time.

[0] Nitrokey/nitrokey-pro-firmware#56
[1] Nitrokey/nitrokey-storage-firmware#81
d-e-s-o pushed a commit to d-e-s-o/nitrocli that referenced this issue Jan 27, 2019
@robinkrahl @d-e-s-o
Check slot status before accessing the PWS
2809a90 
The Nitrokey devices do not check whether a PWS slot is programmed
before accessing it (upstream issues [0] [1]). Until this is fixed in
the firmware, we have to manually check the slot status in pws get. This
could have been done in libnitrokey or the nitrokey crate, yet this
would lead to unnecessary commands if we check multiple fields of a slot
at the same time.

[0] Nitrokey/nitrokey-pro-firmware#56
[1] Nitrokey/nitrokey-storage-firmware#81
@szszszsz szszszsz added the bug label Aug 12, 2019
@szszszsz szszszsz added this to the v0.11 milestone Aug 12, 2019
@szszszsz szszszsz modified the milestones: v0.11, v0.12 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.12
Development

No branches or pull requests
2 participants
@robinkrahl @szszszsz