Mergebot mention in code review does not work

[bhankas]

If merge command is invoked as part of code review that approves the changes, mergebot does not get invoked. A separate, new independent comment is required. While that is fine, a code review with approval is a fairly strong signal. It'd be nice to have it supported.

[Mic92]

The main comment is fine but it shouldn't be part of the comments that one can hide.

[martinetd]

Didn't work in main comment here:
NixOS/nixpkgs#313385

I thought it was because it wasn't the only line in the message, but the code seems to ignore unrelated lines just fine:

    for line in stripped.split("\n"):
        if re.match(rf"^@{bot_name}\s+merge$", line.strip()):
            return merge_command(issue, settings)

So I guess there really is a difference with review?

[Mic92]

I mean it's not implemented but if we implement, we should only accept the main comment of a review. Yes reviews are a different event in the api as far as I know.

[bhankas]

@Mic92 main comment alone should be sufficient.

[sersorrel]

What would be required to implement this?

[Scriptkiddi]

This is because reviews are not comments for the GitHub API. To implement this I need a couple hours maybe some time next week I can get around to fixing this