herdr: fix Darwin builds#536015
Open
arunoruto wants to merge 1 commit into
Open
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
1 task
Contributor
Author
|
13 tasks
kevinpita
suggested changes
Jun 27, 2026
kevinpita
left a comment
kevinpita
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Could you squash the commits before merging?
- Add xcode-select wrapper for darwin builds to fix compilation - Add versionCheckHook for install checks - Fix license and update homepage - Add custom dependency argument to nix-update-script to enable auto-updates of zig dependencies
Contributor
Author
Done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
herdr wasn't building on Darwin systems as can be see in these hydra logs: https://hydra.nixos.org/build/332986051/nixlog/1
To fix this, I added an Xcode select script inspired by the upstream repo and their
package.nixand the cctools. With this, the problem has been fixed.I also added a versionCheckHook just in case (I guess rust projects don't need it really, but better to be safe than sorry).
I checked the licence of the project, and it is an
agpl3Plus, notagpl3Only.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.