Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkdt: 0.7.0 -> 0.9.0 #349979

Merged
merged 1 commit into from
Oct 30, 2024
Merged

vkdt: 0.7.0 -> 0.9.0 #349979

merged 1 commit into from
Oct 30, 2024

Conversation

korrat
Copy link
Contributor

@korrat korrat commented Oct 20, 2024

Updates vkdt to version 0.9.0, including setup for building rust parts of the code.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@korrat
Copy link
Contributor Author

korrat commented Oct 20, 2024

Both binaries start, but I ran into issues getting the GUI to work under wayland. Reported upstream at hanatos/vkdt#142

@korrat korrat mentioned this pull request Oct 20, 2024
@ofborg ofborg bot requested a review from paperdigits October 20, 2024 10:44
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 20, 2024
@paperdigits
Copy link
Contributor

hey, amazing! thank you for taking the time to do this.

Both binaries start, but I ran into issues getting the GUI to work under wayland. Reported upstream at hanatos/vkdt#142

When you say "both binaries start" do you mean vkdt and vkdt-cli? We used to get several binaries, one of them was vkdt-wayland (for wayalnd) and vkdt (for xorg). Not sure why the vkdt-wayland binary is no longer produce.

My other question is can we use the Cargo.lock file in src/pipe/modules/i-raw/rawloader-c/Cargo.lock seen here or is that lock file not sufficient?

@korrat
Copy link
Contributor Author

korrat commented Oct 22, 2024

When you say "both binaries start" do you mean vkdt and vkdt-cli?

Exactly. I also tested out the vkdt-wayland package which seems to be automatically created.

My other question is can we use the Cargo.lock file in src/pipe/modules/i-raw/rawloader-c/Cargo.lock seen here or is that lock file not sufficient?

I tried using the commited Cargo.lock with fetchCargoTarball, but that did not work due to the git dependency. Therefore, I switched to importCargoLock, but that requires the Cargo.lock in nixpkgs, as far as I can tell.

@paperdigits
Copy link
Contributor

Alright, cool. Do we get this merged, since it seems to work if the GPU drivers work?

Copy link
Contributor

@paperdigits paperdigits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks.

@ConnorBaker ConnorBaker merged commit cc88a5e into NixOS:master Oct 30, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants