Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soapysdr: 0.8.1 -> 0.8.2-pre (fix python3.12 compat) #356651

Merged
merged 2 commits into from
Nov 18, 2024
Merged

soapysdr: 0.8.1 -> 0.8.2-pre (fix python3.12 compat) #356651

merged 2 commits into from
Nov 18, 2024

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Nov 17, 2024 •
edited
Loading

soapysdr breaks with Python 3.12. Just update it to latest master since it fixes things and a release hasn't been tagged yet.

See: pothosware/SoapySDR#405 (comment)

Fixing ZHF: https://hydra.nixos.org/build/278238167

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@numinit
soapysdr: 0.8.1 -> 0.8.2-pre (fix python3.12 compat)
1d54f76 
Instead of applying several patches, just use the latest.
The 0.8.2 checklist is mostly done and waiting on a SoapyUHD release,
but we already have Python 3.12 in nixpkgs.

pothosware/SoapySDR#405 (comment)
@numinit numinit added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 17, 2024
@numinit
Copy link
Contributor Author

numinit commented Nov 17, 2024

Result of nixpkgs-review run on x86_64-linux 1 [1/1984]

1 package failed to build:
  • indi-full-nonfree
51 packages built:
  • abracadabra
  • cubicsdr
  • dump1090
  • fm-tune
  • gnss-sdr
  • gnuradio
  • gnuradio3_8
  • gnuradio3_8Packages.ais
  • gnuradio3_8Packages.limesdr
  • gnuradio3_8Packages.osmosdr
  • gnuradio3_8Packages.osmosdr.dev
  • gnuradioMinimal
  • gnuradioPackages.osmosdr
  • gnuradioPackages.osmosdr.dev
  • gqrx
  • gqrx-gr-audio
  • gqrx-portaudio
  • indi-3rdparty.indi-limesdr
  • indi-full
  • kstars
  • limesuite
  • limesuiteWithGui
  • openwebrx
  • openwebrx.dist
  • phd2
  • pothos
  • python311Packages.soapysdr
  • python311Packages.soapysdr-with-plugins
  • python312Packages.soapysdr
  • python312Packages.soapysdr-with-plugins
  • qradiolink
  • rtl_433
  • sdrangel
  • sdrpp
  • sigdigger
  • soapyairspy
  • soapyaudio
  • soapybladerf
  • soapyhackrf
  • soapyremote
  • soapyrtlsdr
  • soapysdr
  • soapysdr-with-plugins
  • soapysdrplay
  • soapyuhd
  • srsran
  • suscan
  • trunk-recorder
  • urh
  • urh.dist
  • welle-io

@numinit numinit added the backport release-24.11 Backport PR automatically label Nov 17, 2024
markuskowa
markuskowa approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
@ofborg ofborg bot requested a review from markuskowa November 17, 2024 18:03
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 17, 2024
@markuskowa markuskowa merged commit 99cb6b5 into NixOS:master Nov 18, 2024
37 of 38 checks passed
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

@markuskowa markuskowa Awaiting requested review from markuskowa

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numinit @markuskowa @wegank