Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-id.sh fails when LANGC #561

Open
Mikael-Lovqvist opened this issue Jul 20, 2024 · 0 comments
Open

build-id.sh fails when LANGC #561

Mikael-Lovqvist opened this issue Jul 20, 2024 · 0 comments
Labels

Comments

@Mikael-Lovqvist
Copy link

Describe the bug

When building on a system with a non C locale, invoking build-id.sh causes pattern matching to fail which fails the test and hence the build.

Steps To Reproduce

The problem can be reproduced using sv_SE.UTF-8 for locale like so:

$ make LANG=sv_SE.UTF-8 check

Expected behavior

Test should succeed no matter the locale when invoking make.

patchelf --version output

config.log contains

#define VERSION "0.17.2"

if that helps.

Additional context

When grepping for output in software that doesn't have a strict structure (which generally should be avoided), one way to minimize risk of error is to force LANG=C for consistent output. This might be done in some cmake shenanigans, in the build-id.sh script or somewhere else. To circumvent the problem one can make sure to invoke everything with LANG=C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant