Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Insample predictions with series of varying lengths #1246

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

marcopeix
Copy link
Contributor

Currently, predict_insample() assumes all series have the same length.

This fix allows insample predictions with series of different lengths.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@marcopeix marcopeix marked this pull request as ready for review January 14, 2025 14:06
nbs/core.ipynb Outdated Show resolved Hide resolved
nbs/core.ipynb Outdated Show resolved Hide resolved
neuralforecast/core.py Show resolved Hide resolved
neuralforecast/core.py Outdated Show resolved Hide resolved
nbs/core.ipynb Show resolved Hide resolved
@marcopeix marcopeix requested a review from elephaint February 7, 2025 17:44
Copy link
Contributor

@elephaint elephaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jose-moralez wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants