Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiDE dense skip connections support #1250

Open
dbalabka opened this issue Jan 21, 2025 · 3 comments
Open

TiDE dense skip connections support #1250

dbalabka opened this issue Jan 21, 2025 · 3 comments

Comments

@dbalabka
Copy link

Description

Nixtla's TiDE implementation only implements residual skip connections. Utilizing the dense skip connection can potentially enhance the forecasting quality metrics.

Use case

Minor model enhancement can improve the forecast metrics.

@elephaint
Copy link
Contributor

Maybe I misunderstand, but if I look at the architecture and the paper the model has been implemented as in the paper which we generally stick to.

We use a residual block where they are in the architecture (in the dense encoders), and a simple linear block for the global skip connection. Note sure where you'd want to add a dense skip connection?

Copy link
Contributor

This issue has been automatically closed because it has been awaiting a response for too long. When you have time to to work with the maintainers to resolve this issue, please post a new comment and it will be re-opened. If the issue has been locked for editing by the time you return to it, please open a new issue and reference this one.

@dbalabka
Copy link
Author

@elephaint, you're right. However, based on experiments, it can improve metrics slightly. Still, w/o the ablation study, there is no evidence that dense skip connection provides any benefit. Let's keep this ticket closed. I'll get back to it with the PR (I've already implemented it) and experiments that should prove my thoughts before making any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants