Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hardcoded name to just Aether and/or remove hardcoding altogether #73

Open
KrisAphalon opened this issue Jan 31, 2020 · 0 comments

Comments

@KrisAphalon
Copy link

Similar to #23 (which I found only now, while creating this issue)

There are several cases in which folder name where the theme is installed is hardcoded, for example: https://github.com/NoiSek/Aether/blob/master/src/js/Logic/FileOperations.js#L16

I had problems with it and manual installation, that I've fixed after tinkering and looking at the source code (praise the open licenses) #72

Other default themes use simple names, such as simple or antegros. I think naming it aether or Aether would be more descriptive, as well as it would simplify changing config a bit. It would be consistent with git repository name as well.

Other possibility is to remove hardcoding altogether, but I don't know how doable it is, or how much work it would require.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant