Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate visualize styling with new mermaid update #636

Closed
zoeyTM opened this issue Dec 4, 2023 · 2 comments
Closed

Evaluate visualize styling with new mermaid update #636

zoeyTM opened this issue Dec 4, 2023 · 2 comments
Assignees

Comments

@zoeyTM
Copy link
Contributor

zoeyTM commented Dec 4, 2023

I recently opened an issue in the mermaidjs repo asking for a config option to add padding around subgraph titles. That issue has now been closed and the feature PR merged into their develop branch, so, pending their next release (presumably v10.6.2), we should reevaluate our graph styles with the new config setting and see if there's an improvement.

@kanej
Copy link
Member

kanej commented Feb 6, 2024

They dropped support for the feature we where waiting on. So this is on ice for the moment.

@kanej kanej closed this as completed Feb 6, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Hardhat Ignition Feb 6, 2024
@zoeyTM zoeyTM reopened this Feb 22, 2024
@zoeyTM zoeyTM moved this from Done to In Progress in Hardhat Ignition Feb 22, 2024
@zoeyTM zoeyTM self-assigned this Feb 22, 2024
@zoeyTM
Copy link
Contributor Author

zoeyTM commented Feb 22, 2024

The feature we were waiting on doesn't seem to have been tested on complex graphs and was broken in ways that makes it unusable for us. This issue is closed now until this PR gets merged, then we can reevaluate.

@zoeyTM zoeyTM closed this as completed Feb 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hardhat Ignition Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants