Syntax highlighting flaws

[tomx-sh]

Hi,
Solidity syntax highlighting seems a bit flawed on VSCode. Using cmd+shift+P>Developer: Inspect Editor Tokens and Scopes, you can verify that:

• some ) characters are not recognized as punctuation.parameters.end (some are)
• some , characters are not recognized as punctuation.separator (some are)
• in >=, the = character is not recognized as part of the keyword.operator.logic. (It is recognized as keyword.operator.assignment instead).

The following image illustrates this using my custom theme:

If you give me some quick directives, I may be able to help fixing this (my experience with ANTLR V4 lexer and parser systems might come useful). I'd be happy to!

[kanej]

Those are great catches, thanks!

The syntax highlighting in vscode is handled by its own built-in system based on textmate grammars. You can find the file here:

hardhat-vscode/client/syntaxes/solidity.json

Line 3 in 98a3935

"name": "Solidity",

[moneyDev1111]

I have the same problem. The tokens exist in your syntax file, they just not being recognized by the editor for some reason...

for me the tokens are not recognized at all
some works, some doesn't for a reason I cannot explain.... hm
theme change doesn't help, settings reset doesn't help, reinstalling the extension doesn't help

[kanej]

I have the same problem. The tokens exist in your syntax file, they just not being recognized by the editor for some reason...

for me the tokens are not recognized at all some works, some doesn't for a reason I cannot explain.... hm theme change doesn't help, settings reset doesn't help, reinstalling the extension doesn't help

Hey @moneyDev1111 is the example above available on github? To help us create a reproduction example.

[moneyDev1111]

@kanej there's no specific steps.. just create a new .sol file inside an empty folder and the bugs are there ( import curly braces, constructor parenthesis etc )

[kanej]

@kanej there's no specific steps.. just create a new .sol file inside an empty folder and the bugs are there ( import curly braces, constructor parenthesis etc )

Hey @moneyDev1111, can you copy and paste a complete the text of a complete Solidity file where you see the issue. I am having trouble reproducing the odd highlighting on for instance the constructor.

[moneyDev1111]

@kanej

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.28;

import {ERC1155} from "@openzeppelin/contracts/token/ERC1155/ERC1155.sol";
import {Ownable} from "@openzeppelin/contracts/access/Ownable.sol";

contract Tickets is ERC1155, Ownable {
    uint256 public constant VIP_TICKET = 0;
    uint256 public constant REGULAR_TICKET = 1;

    constructor() ERC1155("") Ownable(msg.sender) {}

}

here are not only the brackets are missing but the msg.sender as well etc

[moneyDev1111]

also, I guess this is directly relevant, when try saving a file ( that may or may not idk ) contain a syntax error, the formatter cannot do it, it just freezes.. and the file is not getting saved ever.. the popup appears that formatting saving or whatever some file and it cannot finish the task... and yes reinstalling extensions reloading restarting reconfiguring etc doesn't help... idk I would say it's some issue with the vscode itself idk

[kanej]

With that code, I don't get the syntax highlighting oddity:

@antico5 is it possible this could come about due to an error or inconsistency with Semantic Highlightling?

@moneyDev1111 can you check which Solidity related plugins you have installed? And what version the Solidity by Nomic Foundation extension is on?

[moneyDev1111]

@kanej only one by Nomic Foundation. I have very few extensions installed..