Skip to content

Conversation

@gindoslaw
Copy link

Add a small message for the nordvpnlite users.

Problem

example_nordvpnlite_config.json may be a temptation for a copy-paste. Settings are good for software engineers, but also are the trap for new users.

Solution

Add warning at the beginning of the file and point user to the alternative file used in OpenWRT package.

Add small message for the nordvpnlite users
@gindoslaw gindoslaw requested a review from a team as a code owner November 6, 2025 15:59
@nord-llt
Copy link

nord-llt commented Nov 6, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -1,3 +1,7 @@
# This file is not for copy&paste
Copy link
Contributor

@tomasz-grz tomasz-grz Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately JSON format does not support file comments.

And would also cause test_config_example to fail. which is there only to make sure the example config is updated and valid..

The main question is if we actually need example_nordvpnlite_config.json, maybe better documentation instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants