Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded constants #140

Open
talfsaverone opened this issue Feb 7, 2024 · 0 comments
Open

Hard coded constants #140

talfsaverone opened this issue Feb 7, 2024 · 0 comments

Comments

@talfsaverone
Copy link

talfsaverone commented Feb 7, 2024

Hi,

It seems like you have hard coded the timeout values in the writeInternal function from the Uploader class, you use:
val timeout = if (chunk.offset == 0) 40_000L else 2_500L
instead of using the constants from the McuManager class:

    protected final static long DEFAULT_TIMEOUT = 40_000; // ms
    protected final static long SHORT_TIMEOUT = 2_500; // ms

Just wanted to let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant