Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crude support for BITFIELD/BITFIELD_RO #95

Closed
CharlesRaymond1 opened this issue May 31, 2022 · 2 comments
Closed

Crude support for BITFIELD/BITFIELD_RO #95

CharlesRaymond1 opened this issue May 31, 2022 · 2 comments

Comments

@CharlesRaymond1
Copy link
Contributor

There's no current way to support the use case where we want to have support for -ASK or -MOVED with the BITFIELD command. The sole option is to send the BITFIELD command to a single node having the knowledge where this specific key resides (as explained in #50 ). This forces the client to have a sub-optimal flow when using the command.

As the BITFIELD command will always apply to a single key (single slot), there is also no need to parse the sub-commands. Also, redis executes all bitfield sub-commands in the same execution (see https://github.com/redis/redis/blob/unstable/src/bitops.c#L1136)

Optionally, we can support the BITFIELD_RO as a bonus because the only difference is that it supports the GET command.

@CharlesRaymond1
Copy link
Contributor Author

CharlesRaymond1 commented May 31, 2022

Created draft PR: #96

@bjosv
Copy link
Collaborator

bjosv commented Jun 2, 2022

Closed by #96
Thanks!

@bjosv bjosv closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants